Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2119103002: X87: [ia32] Fixes a wrong use of Operand in a test. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ia32] Fixes a wrong use of Operand in a test. port c0d4bb89a1845bcc7a6d865e6c116d53514205ab (r37370) original commit message: Operand(reg) -> reg Operand(reg, 0) -> [reg] BUG= Committed: https://crrev.com/a21bc23d53295f156964593c9ce5753c333d0b82 Cr-Commit-Position: refs/heads/master@{#37489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/cctest/test-assembler-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-04 03:22:42 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-04 03:51:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119103002/1
4 years, 5 months ago (2016-07-04 03:53:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 04:23:08 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 04:23:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a21bc23d53295f156964593c9ce5753c333d0b82
Cr-Commit-Position: refs/heads/master@{#37489}

Powered by Google App Engine
This is Rietveld 408576698