OLD | NEW |
1 // Copyright 2011 the V8 project authors. All rights reserved. | 1 // Copyright 2011 the V8 project authors. All rights reserved. |
2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
4 // met: | 4 // met: |
5 // | 5 // |
6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
409 | 409 |
410 TEST(Regress621926) { | 410 TEST(Regress621926) { |
411 // Bug description: | 411 // Bug description: |
412 // The opcodes for cmpw r/m16, r16 and cmpw r16, r/m16 were swapped. | 412 // The opcodes for cmpw r/m16, r16 and cmpw r16, r/m16 were swapped. |
413 // This was causing non-commutative comparisons to produce the wrong result. | 413 // This was causing non-commutative comparisons to produce the wrong result. |
414 CcTest::InitializeVM(); | 414 CcTest::InitializeVM(); |
415 Isolate* isolate = reinterpret_cast<Isolate*>(CcTest::isolate()); | 415 Isolate* isolate = reinterpret_cast<Isolate*>(CcTest::isolate()); |
416 HandleScope scope(isolate); | 416 HandleScope scope(isolate); |
417 Assembler assm(isolate, nullptr, 0); | 417 Assembler assm(isolate, nullptr, 0); |
418 | 418 |
419 int16_t a = 42; | 419 uint16_t a = 42; |
420 | 420 |
421 Label fail; | 421 Label fail; |
422 __ push(ebx); | 422 __ push(ebx); |
423 __ mov(ebx, Immediate(reinterpret_cast<intptr_t>(&a))); | 423 __ mov(ebx, Immediate(reinterpret_cast<intptr_t>(&a))); |
424 __ mov(eax, Immediate(41)); | 424 __ mov(eax, Immediate(41)); |
425 __ cmpw(eax, Operand(ebx)); | 425 __ cmpw(eax, Operand(ebx, 0)); |
426 __ j(above_equal, &fail); | 426 __ j(above_equal, &fail); |
427 __ cmpw(Operand(ebx), eax); | 427 __ cmpw(Operand(ebx, 0), eax); |
428 __ j(below_equal, &fail); | 428 __ j(below_equal, &fail); |
429 __ mov(eax, 1); | 429 __ mov(eax, 1); |
430 __ pop(ebx); | 430 __ pop(ebx); |
431 __ ret(0); | 431 __ ret(0); |
432 __ bind(&fail); | 432 __ bind(&fail); |
433 __ mov(eax, 0); | 433 __ mov(eax, 0); |
434 __ pop(ebx); | 434 __ pop(ebx); |
435 __ ret(0); | 435 __ ret(0); |
436 | 436 |
437 CodeDesc desc; | 437 CodeDesc desc; |
438 assm.GetCode(&desc); | 438 assm.GetCode(&desc); |
439 Handle<Code> code = isolate->factory()->NewCode( | 439 Handle<Code> code = isolate->factory()->NewCode( |
440 desc, Code::ComputeFlags(Code::STUB), Handle<Code>()); | 440 desc, Code::ComputeFlags(Code::STUB), Handle<Code>()); |
441 | 441 |
442 #ifdef OBJECT_PRINT | 442 #ifdef OBJECT_PRINT |
443 OFStream os(stdout); | 443 OFStream os(stdout); |
444 code->Print(os); | 444 code->Print(os); |
445 #endif | 445 #endif |
446 | 446 |
447 F0 f = FUNCTION_CAST<F0>(code->entry()); | 447 F0 f = FUNCTION_CAST<F0>(code->entry()); |
448 CHECK_EQ(f(), 1); | 448 CHECK_EQ(f(), 1); |
449 } | 449 } |
450 | 450 |
451 #undef __ | 451 #undef __ |
OLD | NEW |