content/shell/browser/shell_devtools_manager_delegate.cc - Issue 2119063002: Add commands to manage tabs and contexts to Browser Domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_manager_delegate.cc

Issue 2119063002: Add commands to manage tabs and contexts to Browser Domain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a check to prevent Browser.closeContext from closing a context that is in use. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/devtools_discovery/devtools_discovery_manager.h ('K') | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | headless/BUILD.gn » ('j') | headless/public/headless_browser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_devtools_manager_delegate.cc

diff --git a/content/shell/browser/shell_devtools_manager_delegate.cc b/content/shell/browser/shell_devtools_manager_delegate.cc

index c360d970c4663df851016373be4d7624d2b4aedd..db66012a96f5b3e40baaa57b5b8caa4781546cf3 100644

--- a/content/shell/browser/shell_devtools_manager_delegate.cc

+++ b/content/shell/browser/shell_devtools_manager_delegate.cc

@@ -229,8 +229,9 @@ ShellDevToolsManagerDelegate::~ShellDevToolsManagerDelegate() {

base::DictionaryValue* ShellDevToolsManagerDelegate::HandleCommand(

DevToolsAgentHost* agent_host,

- base::DictionaryValue* command) {

- return NULL;

+ base::DictionaryValue* command_dict) {

+ return devtools_discovery::DevToolsDiscoveryManager::GetInstance()

+ ->MaybeHandleNewPageCommand(command_dict);

}

} // namespace content