components/devtools_discovery/devtools_discovery_manager.h - Issue 2119063002: Add commands to manage tabs and contexts to Browser Domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_discovery/devtools_discovery_manager.h

Issue 2119063002: Add commands to manage tabs and contexts to Browser Domain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a check to prevent Browser.closeContext from closing a context that is in use. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.cc ('k') | components/devtools_discovery/devtools_discovery_manager.cc » ('j') | headless/public/headless_browser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_discovery/devtools_discovery_manager.h

diff --git a/components/devtools_discovery/devtools_discovery_manager.h b/components/devtools_discovery/devtools_discovery_manager.h

index 75657d46be6a32462680f60ab271d02da89ee56b..bb1425946a47100b5385353b10ede33b894c4c01 100644

--- a/components/devtools_discovery/devtools_discovery_manager.h

+++ b/components/devtools_discovery/devtools_discovery_manager.h

@@ -10,6 +10,7 @@

#include "base/macros.h"

#include "base/memory/singleton.h"

+#include "base/values.h"

#include "components/devtools_discovery/devtools_target_descriptor.h"

namespace devtools_discovery {

@@ -39,6 +40,10 @@ class DevToolsDiscoveryManager {

DevToolsTargetDescriptor::List GetDescriptors();

std::unique_ptr<DevToolsTargetDescriptor> CreateNew(const GURL& url);

+ // Handles Browser.newPage only.

+ base::DictionaryValue* MaybeHandleNewPageCommand(

Sami 2016/07/04 15:28:54 unique_ptr<base::DictionaryValue> to pass ownershi

alex clarke (OOO till 29th) 2016/07/04 16:33:59 Done.

+ base::DictionaryValue* command_dict);

private:

friend struct base::DefaultSingletonTraits<DevToolsDiscoveryManager>;