Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Unified Diff: chrome/browser/ui/cocoa/location_bar/verbose_state_bubble_decoration_unittest.mm

Issue 2119033002: [Material][Mac] Implement Omnibox Verbose State Chips (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/verbose_state_bubble_decoration_unittest.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration_unittest.mm b/chrome/browser/ui/cocoa/location_bar/verbose_state_bubble_decoration_unittest.mm
similarity index 73%
rename from chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration_unittest.mm
rename to chrome/browser/ui/cocoa/location_bar/verbose_state_bubble_decoration_unittest.mm
index e898e20b7f49bb6977fb8f94e736d193bac859ee..8c46c6a292187c6ea9fdd56e44c48e20a94661b1 100644
--- a/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration_unittest.mm
+++ b/chrome/browser/ui/cocoa/location_bar/verbose_state_bubble_decoration_unittest.mm
@@ -4,27 +4,28 @@
#import <Cocoa/Cocoa.h>
-#import "chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h"
+#import "chrome/browser/ui/cocoa/location_bar/verbose_state_bubble_decoration.h"
#import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
+#import "chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
-class EVBubbleDecorationTest : public CocoaTest {
+class VerboseStateBubbleDecorationTest : public CocoaTest {
public:
- EVBubbleDecorationTest() : decoration_(NULL) {
- }
+ VerboseStateBubbleDecorationTest() : icon_(NULL), decoration_(&icon_, NULL) {}
Robert Sesek 2016/08/16 22:25:33 NULL -> nullptr
spqchan 2016/08/17 00:41:18 Done.
- EVBubbleDecoration decoration_;
+ LocationIconDecoration icon_;
+ VerboseStateBubbleDecoration decoration_;
};
// Test that the decoration gets smaller when there's not enough space
// to fit, within bounds.
-TEST_F(EVBubbleDecorationTest, MiddleElide) {
+TEST_F(VerboseStateBubbleDecorationTest, MiddleElide) {
NSString* kLongString = @"A very long string with spaces";
- const CGFloat kWide = 1000.0; // Wide enough to fit everything.
- const CGFloat kNarrow = 10.0; // Too narrow for anything.
+ const CGFloat kWide = 1000.0; // Wide enough to fit everything.
+ const CGFloat kNarrow = 10.0; // Too narrow for anything.
const CGFloat kMinimumWidth = 100.0; // Never should get this small.
const NSSize kImageSize = NSMakeSize(20.0, 20.0);

Powered by Google App Engine
This is Rietveld 408576698