Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 2118993002: Detemplatize cc property nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
index 6ef8b4e5949d332e6c7a5ba8ed916dd1e7b22006..beccf1b5ba0a73f9883229edb7faf9fc267664d4 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
@@ -11,8 +11,11 @@
#include "cc/playback/display_item_list_settings.h"
#include "cc/playback/drawing_display_item.h"
#include "cc/playback/transform_display_item.h"
+#include "cc/trees/clip_node.h"
+#include "cc/trees/effect_node.h"
#include "cc/trees/layer_tree_host.h"
#include "cc/trees/property_tree.h"
+#include "cc/trees/transform_node.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/graphics/paint/ClipPaintPropertyNode.h"
#include "platform/graphics/paint/DisplayItem.h"
@@ -271,7 +274,7 @@ void setMinimalPropertyTrees(cc::PropertyTrees* propertyTrees, int ownerId)
transformTree.clear();
cc::TransformNode& transformNode = *transformTree.Node(transformTree.Insert(cc::TransformNode(), kRealRootNodeId));
DCHECK_EQ(transformNode.id, kSecondaryRootNodeId);
- transformNode.data.source_node_id = transformNode.parent_id;
+ transformNode.source_node_id = transformNode.parent_id;
transformTree.SetTargetId(transformNode.id, kRealRootNodeId);
transformTree.SetContentTargetId(transformNode.id, kRealRootNodeId);
@@ -288,8 +291,8 @@ void setMinimalPropertyTrees(cc::PropertyTrees* propertyTrees, int ownerId)
cc::EffectNode& effectNode = *effectTree.Node(effectTree.Insert(cc::EffectNode(), kRealRootNodeId));
DCHECK_EQ(effectNode.id, kSecondaryRootNodeId);
effectNode.owner_id = ownerId;
- effectNode.data.clip_id = clipNode.id;
- effectNode.data.has_render_surface = true;
+ effectNode.clip_id = clipNode.id;
+ effectNode.has_render_surface = true;
cc::ScrollTree& scrollTree = propertyTrees->scroll_tree;
scrollTree.clear();
@@ -409,15 +412,15 @@ int TransformTreeManager::compositorIdForNode(const TransformPaintPropertyNode*
cc::TransformNode& compositorNode = *m_transformTree.Node(id);
m_transformTree.SetTargetId(id, kRealRootNodeId);
m_transformTree.SetContentTargetId(id, kRealRootNodeId);
- compositorNode.data.source_node_id = parentId;
+ compositorNode.source_node_id = parentId;
FloatPoint3D origin = transformNode->origin();
- compositorNode.data.pre_local.matrix().setTranslate(
+ compositorNode.pre_local.matrix().setTranslate(
-origin.x(), -origin.y(), -origin.z());
- compositorNode.data.local.matrix() = TransformationMatrix::toSkMatrix44(transformNode->matrix());
- compositorNode.data.post_local.matrix().setTranslate(
+ compositorNode.local.matrix() = TransformationMatrix::toSkMatrix44(transformNode->matrix());
+ compositorNode.post_local.matrix().setTranslate(
origin.x(), origin.y(), origin.z());
- compositorNode.data.needs_local_transform_update = true;
+ compositorNode.needs_local_transform_update = true;
m_rootLayer->AddChild(dummyLayer);
dummyLayer->SetTransformTreeIndex(id);
« no previous file with comments | « cc/trees/tree_synchronizer_unittest.cc ('k') | ui/gfx/transform.h » ('j') | ui/gfx/transform.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698