Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2118973003: Merge "Update a comment and fix a possible crash in HTMLSelectElement::setRecalcListItems." to M53. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge "Update a comment and fix a possible crash in HTMLSelectElement::setRecalcListItems." to M53. This is a follow-up of crrev.com/403093. - Replace a TODO comment with an explanation, and add a test to reproduce the scenario. - Fix a possible crash by m_listItems.remove(WTF::kNotFound) just in case. We don't find a reproduction. BUG=625050, 625091 Review-Url: https://codereview.chromium.org/2103663006 Cr-Commit-Position: refs/heads/master@{#403416} (cherry picked from commit 760c56deb503e184f25a77782e743b6d46732cb6) Committed: https://chromium.googlesource.com/chromium/src/+/3fe2c3902b205e99caff0e774a1b4d19c019276d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 5 months ago (2016-07-01 22:36:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fe2c3902b205e99caff0e774a1b4d19c019276d.

Powered by Google App Engine
This is Rietveld 408576698