Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Issue 2103663006: Update a comment and fix a possible crash in HTMLSelectElement::setRecalcListItems. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a comment and fix a possible crash in HTMLSelectElement::setRecalcListItems. This is a follow-up of crrev.com/403093. - Replace a TODO comment with an explanation, and add a test to reproduce the scenario. - Fix a possible crash by m_listItems.remove(WTF::kNotFound) just in case. We don't find a reproduction. BUG=625050 Committed: https://crrev.com/760c56deb503e184f25a77782e743b6d46732cb6 Cr-Commit-Position: refs/heads/master@{#403416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-06-30 07:48:39 UTC) #3
keishi
LGTM
4 years, 5 months ago (2016-07-01 01:12:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103663006/1
4 years, 5 months ago (2016-07-01 01:19:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/248985)
4 years, 5 months ago (2016-07-01 03:18:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103663006/1
4 years, 5 months ago (2016-07-01 05:21:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 06:28:57 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 06:29:02 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 06:30:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/760c56deb503e184f25a77782e743b6d46732cb6
Cr-Commit-Position: refs/heads/master@{#403416}

Powered by Google App Engine
This is Rietveld 408576698