Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2118923002: Add --hot-reload-test-mode flag to embedder and wire it up to test.py (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --hot-reload-test-mode flag to embedder and wire it up to test.py - [x] Add --hot-reload-test-mode to standalone embedder. - [x] Have test.py pass `--hot-reload-test-mode` instead of specific flags. - [x] Add --reload_every_back_off flag to control exponential backof off reloads. - [x] Add --check_reloaded flag to ensure that an isolate has reloaded at least once before exiting. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/621ce4e2fd402015fcdd9a46ea4b361f1437ba26

Patch Set 1 #

Total comments: 2

Patch Set 2 : more tweaks #

Patch Set 3 : rmacnak review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M runtime/bin/main.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/isolate_reload.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Cutch
4 years, 5 months ago (2016-07-01 19:41:57 UTC) #4
rmacnak
lgtm https://codereview.chromium.org/2118923002/diff/1/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): https://codereview.chromium.org/2118923002/diff/1/runtime/vm/isolate.cc#newcode1700 runtime/vm/isolate.cc:1700: OS::PrintErr("Isolate did not reload before exiting and " ...
4 years, 5 months ago (2016-07-01 20:53:22 UTC) #5
Cutch
Committed patchset #3 (id:40001) manually as 621ce4e2fd402015fcdd9a46ea4b361f1437ba26 (presubmit successful).
4 years, 5 months ago (2016-07-01 21:26:30 UTC) #7
Cutch
4 years, 5 months ago (2016-07-01 21:26:40 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/2118923002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2118923002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1700: OS::PrintErr("Isolate did not reload before exiting
and "
On 2016/07/01 20:53:22, rmacnak wrote:
> FATAL("...")

Done.

Powered by Google App Engine
This is Rietveld 408576698