Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2118923002: Add --hot-reload-test-mode flag to embedder and wire it up to test.py (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rmacnak review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 4e129e81b6c085566c960dfcddb88d2d11a27bbd..76a0e5577764e0821831e205bfba20ff427f21b4 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -179,8 +179,9 @@ class NoneCompilerConfiguration extends CompilerConfiguration {
args.add('--enable_type_checks');
}
if (hotReload) {
- args.add('--identity-reload');
- args.add('--reload-every=100000');
+ args.add('--hot-reload-test-mode');
+ // Remove the following once known bugs with background compilation
+ // and OSR are fixed.
args.add('--no-background-compilation');
args.add('--no-osr');
}
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698