Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2118903003: Relocate tests from fast/svg/ to svg/ (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-fast-svg-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relocate tests from fast/svg/ to svg/ Some files are renamed to avoid name clashes on case-insensitive file-systems: svgangle.html => svgangle-units.html svglength.html => svglength-units.html svglist.html => svglist-basic-interface.html (The last one did not actually clash, but was renamed for easier differentiation.) BUG=625231 Committed: https://crrev.com/2bd73d9eff173e4f9c1ecaf99a3c9a3a5aa40037 Cr-Commit-Position: refs/heads/master@{#403511}

Patch Set 1 #

Patch Set 2 : Rename some files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-21 lines, -12096 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/SVGStyleElement.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/foreign-object-case-sensitivity.html View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/foreign-object-case-sensitivity-expected.txt View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/getScreenCTM.html View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/getbbox.html View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/href-baseval-animval.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/linear-gradient-default-length.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/no-fixed-in-svg-assert.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/no-fixed-in-svg-assert-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/resources/whitespace-helper.js View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/svgangle.html View 1 chunk +0 lines, -188 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/svglength.html View 1 chunk +0 lines, -189 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/svglist.html View 1 chunk +0 lines, -129 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/tabindex-focus.html View 1 chunk +0 lines, -205 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/whitespace-angle.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/whitespace-angle-expected.txt View 1 chunk +0 lines, -4351 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/whitespace-integer.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/whitespace-integer-expected.txt View 1 chunk +0 lines, -1313 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/whitespace-length.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/whitespace-length-expected.txt View 1 chunk +0 lines, -2537 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/whitespace-number.html View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/whitespace-number-expected.txt View 1 chunk +0 lines, -2569 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/no-fixed-in-svg-assert.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/no-fixed-in-svg-assert-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/SVGStyleElement.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/getScreenCTM.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/getbbox.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/href-baseval-animval.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/linear-gradient-default-length.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/svgangle-units.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/svglength-units.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/svglist-basic-interface.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/dom/tabindex-focus.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/foreign-object-case-sensitivity-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/resources/whitespace-helper.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-angle.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-integer-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-length.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-length-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-number.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-number-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
fs
...and these are the "plain moves" (modulo renames...)
4 years, 5 months ago (2016-07-01 19:29:08 UTC) #3
pdr.
LGTM
4 years, 5 months ago (2016-07-01 19:51:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118903003/20001
4 years, 5 months ago (2016-07-01 20:14:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 20:20:16 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 20:20:28 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 20:22:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bd73d9eff173e4f9c1ecaf99a3c9a3a5aa40037
Cr-Commit-Position: refs/heads/master@{#403511}

Powered by Google App Engine
This is Rietveld 408576698