Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2112373002: Fold fast/svg/script-tests/animation-events.js into the test using it (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
pdr., Stephen Chennney
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fold fast/svg/script-tests/animation-events.js into the test using it There's only one test using this "framework", so fold it into the test itself. Move the result to svg/animation/. Straight copy of the .js file into the .html file. Whitespace is adjusted and some redundant things are removed (';' and <div>.) BUG=625231 Committed: https://crrev.com/9021fe63f554128b2a26db6486e862c8fb10fc6f Cr-Commit-Position: refs/heads/master@{#403510}

Patch Set 1 #

Patch Set 2 : Actually move the test... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -101 lines) Patch
M third_party/WebKit/LayoutTests/fast/svg/animation-events.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/svg/script-tests/animation-events.js View 1 chunk +0 lines, -73 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/animations/animation-events.html View 1 2 chunks +27 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
fs
Separated this out because I felt the need to merge these two files while at ...
4 years, 5 months ago (2016-07-01 19:27:29 UTC) #3
pdr.
LGTM
4 years, 5 months ago (2016-07-01 19:50:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112373002/20001
4 years, 5 months ago (2016-07-01 19:57:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 20:10:34 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 20:10:51 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 20:13:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9021fe63f554128b2a26db6486e862c8fb10fc6f
Cr-Commit-Position: refs/heads/master@{#403510}

Powered by Google App Engine
This is Rietveld 408576698