third_party/WebKit/public/platform/scheduler/DEPS - Issue 2118903002: scheduler: Move the Blink scheduler into Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/scheduler/DEPS

Issue 2118903002: scheduler: Move the Blink scheduler into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another GYP fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/public/blink_headers.gypi ('K') | « third_party/WebKit/public/platform/scheduler/.clang-format ('k') | third_party/WebKit/public/platform/scheduler/OWNERS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+base/bind.h",

	3 "+base/callback.h",

	4 "+base/macros.h",

	5 "+base/memory/ptr_util.h",

	6 "+base/memory/ref_counted.h",
	esprehn 2016/07/22 06:12:11 we'll want to switch to WTF stuff after moving the we'll want to switch to WTF stuff after moving the code, but all of this is fine to get started. Sami 2016/07/29 17:03:27 Acknowledged. Show quoted text On 2016/07/22 06:12:11, esprehn wrote: > we'll want to switch to WTF stuff after moving the code, but all of this is fine > to get started. Acknowledged.
	7 "+base/message_loop/message_loop.h",

	8 "+base/single_thread_task_runner.h",

	9 "+base/threading/thread.h",

	10 "+base/time/time.h",

	11 "+public/web/WebInputEvent.h",
	esprehn 2016/07/22 06:12:11 platform actually can't depend on web/ https://cs platform actually can't depend on web/ https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/DEPS?... it's a layering violation since web is above platform, that said we should actually move WebInputEvent into platform/ it belongs in here. I would do that first. To make it easier so you don't need to update several hundred files you can leave a proxy header in web that just includes the one from platform. dtapuska 2016/07/22 14:40:18 See: https://codereview.chromium.org/2173073003 I' Show quoted text On 2016/07/22 06:12:11, esprehn wrote: > platform actually can't depend on web/ > > https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/DEPS?... > > it's a layering violation since web is above platform, that said we should > actually move WebInputEvent into platform/ it belongs in here. I would do that > first. To make it easier so you don't need to update several hundred files you > can leave a proxy header in web that just includes the one from platform. See: https://codereview.chromium.org/2173073003 I've had this in my backlog for a while. Sami 2016/07/29 17:03:27 Thanks a lot Dave! I've now removed this dep. Show quoted text On 2016/07/22 14:40:18, dtapuska wrote: > On 2016/07/22 06:12:11, esprehn wrote: > > platform actually can't depend on web/ > > > > > https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/DEPS?... > > > > it's a layering violation since web is above platform, that said we should > > actually move WebInputEvent into platform/ it belongs in here. I would do that > > first. To make it easier so you don't need to update several hundred files you > > can leave a proxy header in web that just includes the one from platform. > > See: https://codereview.chromium.org/2173073003 I've had this in my backlog for > a while. Thanks a lot Dave! I've now removed this dep.
	12 "+v8/include/v8.h",

	13 ]

OLD	NEW