Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2173073003: Move WebInputEvent into public/platform from public/web (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dtapuska+chromiumwatch_chromium.org, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebInputEvent into public/platform from public/web Some preliminary work to remove PlatformEvent abstractions. Rename a constant to pass check-webkit-style. BUG=625684 TBR=rbyers@chromium.org Committed: https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737 Cr-Commit-Position: refs/heads/master@{#407186}

Patch Set 1 #

Patch Set 2 : Fix build failures #

Patch Set 3 : One more missing WebTouchPoint #

Patch Set 4 : Fix android build #

Patch Set 5 : Fix gn build failure with android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -736 lines) Patch
M components/test_runner/event_sender.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/test_runner/event_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/test_plugin.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer_action.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/input/event_with_latency_info.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/input/synthetic_web_input_event_builders.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/event_conversion.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 2 3 chunks +2 lines, -1 line 0 comments Download
A + third_party/WebKit/public/platform/WebInputEvent.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/public/platform/WebTouchPoint.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/public/web/WebInputEvent.h View 1 2 1 chunk +3 lines, -622 lines 0 comments Download
D third_party/WebKit/public/web/WebTouchPoint.h View 1 chunk +0 lines, -75 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (24 generated)
dtapuska
4 years, 5 months ago (2016-07-22 14:33:18 UTC) #2
dtapuska
tdresser@chromium.org: Please review changes in
4 years, 5 months ago (2016-07-22 14:33:54 UTC) #6
esprehn
It doesn't appear to build but rs lgtm once it does, thanks so much for ...
4 years, 5 months ago (2016-07-22 15:36:26 UTC) #17
tdresser
LGTM
4 years, 5 months ago (2016-07-22 16:41:06 UTC) #20
dtapuska
rbyers@chromium.org: Please review changes in TBR'ng you
4 years, 5 months ago (2016-07-22 17:11:04 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173073003/80001
4 years, 5 months ago (2016-07-22 17:11:57 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-22 17:16:44 UTC) #30
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:18:56 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737
Cr-Commit-Position: refs/heads/master@{#407186}

Powered by Google App Engine
This is Rietveld 408576698