Fix vulkan image sampling

Fix vulkan image sampling

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118733005

Committed: https://skia.googlesource.com/skia/+/2f5792a06c87efd5f9295b7b7bb714aac118bd2a

[egdaniel, 2016-07-01 19:34:18]

Description was changed from

==========
Fix vulkan image sampling

BUG=skia:
==========

to

==========
Fix vulkan image sampling

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118733005
==========

[egdaniel, 2016-07-01 19:34:41]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[egdaniel, 2016-07-01 20:20:22]

egdaniel@google.com changed reviewers:
+ brianosman@google.com, bsalomon@google.com

[egdaniel, 2016-07-01 20:20:23]

https://codereview.chromium.org/2118733005/diff/20001/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/2118733005/diff/20001/src/gpu/vk/GrVkGpu.cpp#...
src/gpu/vk/GrVkGpu.cpp:790: }
On Nvidia, there seems to be a driver bug in blitting to create the mip maps. We
can land this CL as is which will occasionally draw corrupted triangles on on
parts of images we've mipmaped. This does not repro on the 5X. A work around
that seems to work is simply submitting the current command buffer here (doens't
need a sync) before blitting. We can wrap this is some cap that is set on Nvidia
only (but then we may not notice if their driver fixes it).

[bsalomon, 2016-07-02 00:50:12]

lgtm

https://codereview.chromium.org/2118733005/diff/20001/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/2118733005/diff/20001/src/gpu/vk/GrVkGpu.cpp#...
src/gpu/vk/GrVkGpu.cpp:790: }
On 2016/07/01 20:20:22, egdaniel wrote:
> On Nvidia, there seems to be a driver bug in blitting to create the mip maps.
We
> can land this CL as is which will occasionally draw corrupted triangles on on
> parts of images we've mipmaped. This does not repro on the 5X. A work around
> that seems to work is simply submitting the current command buffer here
(doens't
> need a sync) before blitting. We can wrap this is some cap that is set on
Nvidia
> only (but then we may not notice if their driver fixes it).

I leave it to you whether you want to workaround the bug or not. It'd be a good
to submit a bug to NV so they can fix it. Then we'd also probably know when to
remove the workaround after the fix.

[jvanverth1, 2016-07-06 15:19:42]

https://codereview.chromium.org/2118733005/diff/20001/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/2118733005/diff/20001/src/gpu/vk/GrVkGpu.cpp#...
src/gpu/vk/GrVkGpu.cpp:790: }
On 2016/07/02 00:50:12, bsalomon wrote:
> On 2016/07/01 20:20:22, egdaniel wrote:
> > On Nvidia, there seems to be a driver bug in blitting to create the mip
maps.
> We
> > can land this CL as is which will occasionally draw corrupted triangles on
on
> > parts of images we've mipmaped. This does not repro on the 5X. A work around
> > that seems to work is simply submitting the current command buffer here
> (doens't
> > need a sync) before blitting. We can wrap this is some cap that is set on
> Nvidia
> > only (but then we may not notice if their driver fixes it).
> 
> I leave it to you whether you want to workaround the bug or not. It'd be a
good
> to submit a bug to NV so they can fix it. Then we'd also probably know when to
> remove the workaround after the fix.

I'm fine with landing this as is, and creating a separate patch that submits the
command buffer.

[egdaniel, 2016-07-06 15:22:52]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-07-06 15:22:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 15:51:25]

Description was changed from

==========
Fix vulkan image sampling

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118733005
==========

to

==========
Fix vulkan image sampling

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118733005

Committed:
https://skia.googlesource.com/skia/+/2f5792a06c87efd5f9295b7b7bb714aac118bd2a
==========

[commit-bot: I haz the power, 2016-07-06 15:51:26]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2f5792a06c87efd5f9295b7b7bb714aac118bd2a