[interpeter] Move to table based peephole optimizer.

src/v8.gyp

Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index e3262fff347d165ed6c137d098b86c5f1aa0adc2..b3428e4e7142caadb5ce9d4598a21e7e14fd4d59 100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -35,6 +35,7 @@
     'v8_extra_library_files%': [],
     'v8_experimental_extra_library_files%': [],
     'mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
+    'mkpeephole_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mkpeephole<(EXECUTABLE_SUFFIX)',
   },
   'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi'],
   'targets': [
@@ -379,6 +380,7 @@
       'target_name': 'v8_base',
       'type': 'static_library',
       'dependencies': [
+        'peephole_table_data',
         'v8_libbase',
         'v8_libsampler',
       ],
@@ -388,6 +390,7 @@
       'include_dirs+': [
         '..',
         '<(DEPTH)',
+        '<(SHARED_INTERMEDIATE_DIR)'
       ],
       'sources': [  ### gcmole(all) ###
         '../include/v8-debug.h',
@@ -921,6 +924,7 @@
         'interpreter/bytecode-generator.h',
         'interpreter/bytecode-peephole-optimizer.cc',
         'interpreter/bytecode-peephole-optimizer.h',
+        '<(INTERMEDIATE_DIR)/bytecode-peephole-table.h',

[rmcilroy, 2016/07/08 13:18:25]

Same comment as gn file.

[oth, 2016/07/08 15:12:34]

Here there are explicit dependencies on the generation of the file. So part A of
your comment is again mistaken.

Same comment for part B. I suspect we have to do as you suggest for the gcmole
build. I don't see conflating this with the snapshot path as having any other
benefit.

         'interpreter/bytecode-pipeline.cc',
         'interpreter/bytecode-pipeline.h',
         'interpreter/bytecode-register-allocator.cc',
@@ -2296,5 +2300,58 @@
         }],
       ],
     },
+    {
+      'target_name': 'mkpeephole',
+      'type': 'executable',
+      'dependencies': [ 'v8_libbase' ],
+      'include_dirs+': [
+        '..',
+       ],
+      'sources': [
+        'interpreter/bytecode-register-optimizer.h',
+        'interpreter/bytecodes.h',
+        'interpreter/bytecodes.cc',
+        'interpreter/mkpeephole.cc'
+      ],
+      'conditions': [
+        ['want_separate_host_toolset==1', {
+          'toolsets': ['host'],
+        }, {
+          'toolsets': ['target'],
+        }],
+      ],
+    },
+    {
+      'target_name': 'run_mkpeephole_on_host',
+      'type': 'none',
+      'dependencies': ['mkpeephole'],
+      'actions': [
+      {
+        'action_name': 'run_mkpeephole',
+        'inputs': ['<(mkpeephole_exec)'],
+        'outputs': ['<(SHARED_INTERMEDIATE_DIR)/bytecode-peephole-table.h'],
+        'action': ['<(mkpeephole_exec)', '<(SHARED_INTERMEDIATE_DIR)/bytecode-peephole-table.h' ]
+      }],
+      'conditions': [
+        ['want_separate_host_toolset==1', {
+          'toolsets': ['host'],
+        }, {
+          'toolsets': ['target'],
+        }],
+      ],
+    },
+    {
+      'target_name': 'peephole_table_data',
+      'type': 'none',
+      'conditions': [
+        ['want_separate_host_toolset==1', {
+          'toolsets': ['target', 'host'],
+          'dependencies': ['run_mkpeephole_on_host#host']
+        }, {
+          'toolsets': ['target'],
+          'dependencies': ['run_mkpeephole_on_host']
+        }],
+      ],
+    },
   ],
 }