[interpeter] Move to table based peephole optimizer.

src/v8.gyp

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 17 matching lines @@
 {
   'variables': {
     'v8_code': 1,
     'v8_random_seed%': 314159265,
     'v8_vector_stores%': 0,
     'embed_script%': "",
     'warmup_script%': "",
     'v8_extra_library_files%': [],
     'v8_experimental_extra_library_files%': [],
     'mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
+    'mkpeephole_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mkpeephole<(EXECUTABLE_SUFFIX)',
   },
   'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi'],
   'targets': [
     {
       'target_name': 'v8',
       'dependencies_traverse': 1,
       'dependencies': ['v8_maybe_snapshot'],
       'conditions': [
         ['want_separate_host_toolset==1', {
           'toolsets': ['host', 'target'],
@@ skipping 324 matching lines @@
               ],
             },
           ],
         }],
       ],
     },
     {
       'target_name': 'v8_base',
       'type': 'static_library',
       'dependencies': [
+        'peephole_table_data',
         'v8_libbase',
         'v8_libsampler',
       ],
       'variables': {
         'optimize': 'max',
       },
       'include_dirs+': [
         '..',
         '<(DEPTH)',
+        '<(SHARED_INTERMEDIATE_DIR)'
       ],
       'sources': [  ### gcmole(all) ###
         '../include/v8-debug.h',
         '../include/v8-experimental.h',
         '../include/v8-platform.h',
         '../include/v8-profiler.h',
         '../include/v8-testing.h',
         '../include/v8-util.h',
         '../include/v8-version.h',
         '../include/v8.h',
@@ skipping 513 matching lines @@
         'interpreter/bytecode-array-iterator.h',
         'interpreter/bytecode-array-writer.cc',
         'interpreter/bytecode-array-writer.h',
         'interpreter/bytecode-dead-code-optimizer.cc',
         'interpreter/bytecode-dead-code-optimizer.h',
         'interpreter/bytecode-label.h',
         'interpreter/bytecode-generator.cc',
         'interpreter/bytecode-generator.h',
         'interpreter/bytecode-peephole-optimizer.cc',
         'interpreter/bytecode-peephole-optimizer.h',
+        '<(INTERMEDIATE_DIR)/bytecode-peephole-table.h',

[rmcilroy, 2016/07/08 13:18:25]

Same comment as gn file.

[oth, 2016/07/08 15:12:34]

Here there are explicit dependencies on the generation of the file. So part A of
your comment is again mistaken.

Same comment for part B. I suspect we have to do as you suggest for the gcmole
build. I don't see conflating this with the snapshot path as having any other
benefit.

         'interpreter/bytecode-pipeline.cc',
         'interpreter/bytecode-pipeline.h',
         'interpreter/bytecode-register-allocator.cc',
         'interpreter/bytecode-register-allocator.h',
         'interpreter/bytecode-register-optimizer.cc',
         'interpreter/bytecode-register-optimizer.h',
         'interpreter/bytecode-traits.h',
         'interpreter/constant-array-builder.cc',
         'interpreter/constant-array-builder.h',
         'interpreter/control-flow-builders.cc',
@@ skipping 1355 matching lines @@
             '<(icu_gyp_path):icuuc',
           ]
         }],
         ['want_separate_host_toolset==1', {
           'toolsets': ['host'],
         }, {
           'toolsets': ['target'],
         }],
       ],
     },
+    {
+      'target_name': 'mkpeephole',
+      'type': 'executable',
+      'dependencies': [ 'v8_libbase' ],
+      'include_dirs+': [
+        '..',
+       ],
+      'sources': [
+        'interpreter/bytecode-register-optimizer.h',
+        'interpreter/bytecodes.h',
+        'interpreter/bytecodes.cc',
+        'interpreter/mkpeephole.cc'
+      ],
+      'conditions': [
+        ['want_separate_host_toolset==1', {
+          'toolsets': ['host'],
+        }, {
+          'toolsets': ['target'],
+        }],
+      ],
+    },
+    {
+      'target_name': 'run_mkpeephole_on_host',
+      'type': 'none',
+      'dependencies': ['mkpeephole'],
+      'actions': [
+      {
+        'action_name': 'run_mkpeephole',
+        'inputs': ['<(mkpeephole_exec)'],
+        'outputs': ['<(SHARED_INTERMEDIATE_DIR)/bytecode-peephole-table.h'],
+        'action': ['<(mkpeephole_exec)', '<(SHARED_INTERMEDIATE_DIR)/bytecode-peephole-table.h' ]
+      }],
+      'conditions': [
+        ['want_separate_host_toolset==1', {
+          'toolsets': ['host'],
+        }, {
+          'toolsets': ['target'],
+        }],
+      ],
+    },
+    {
+      'target_name': 'peephole_table_data',
+      'type': 'none',
+      'conditions': [
+        ['want_separate_host_toolset==1', {
+          'toolsets': ['target', 'host'],
+          'dependencies': ['run_mkpeephole_on_host#host']
+        }, {
+          'toolsets': ['target'],
+          'dependencies': ['run_mkpeephole_on_host']
+        }],
+      ],
+    },
   ],
 }