value-set-view must select the 0th tab even if it is the only one

value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing, so this CL adds
an automated test for value-set-view.

BUG=chromium:625064
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a2f2ef7632acbf868fdfe86391a12a5f9ac60438

[benjhayden, 2016-07-01 22:08:31]

Description was changed from

==========
value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing.
==========

to

==========
value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing, so this CL adds
an automated test for value-set-view.
==========

[benjhayden, 2016-07-01 22:08:57]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org, nednguyen@google.com, zhenw@chromium.org

[benjhayden, 2016-07-01 22:08:57]

PTAL :-)

[benjhayden, 2016-07-01 22:09:33]

Description was changed from

==========
value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing, so this CL adds
an automated test for value-set-view.
==========

to

==========
value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing, so this CL adds
an automated test for value-set-view.

BUG=#625064
==========

[eakuefner, 2016-07-06 18:33:34]

lgtm

nit: BUG= should be prefixed with chromium: (no # if it's not github)

Syntax for Chromium is chromium:123123 and for Catapult is catapult:#1231 so
that Catapult bugs will be linkified on Github.

[benjhayden, 2016-07-06 20:49:56]

Description was changed from

==========
value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing, so this CL adds
an automated test for value-set-view.

BUG=#625064
==========

to

==========
value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing, so this CL adds
an automated test for value-set-view.

BUG=chromium:625064
==========

[benjhayden, 2016-07-06 20:59:06]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2016-07-06 20:59:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 22:19:31]

Description was changed from

==========
value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing, so this CL adds
an automated test for value-set-view.

BUG=chromium:625064
==========

to

==========
value-set-view must select the 0th tab even if it is the only one

Currently, value-set-view assumes that tab-view will select the 0th tab if it is
the only one, but this is not the case. Value-set-view must explicitly select
the 0th tab in order for it to be visible. Value-set-view's use of Settings to
remember selected tabs hid this bug during my manual testing, so this CL adds
an automated test for value-set-view.

BUG=chromium:625064

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-06 22:19:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[commit-bot: I haz the power, 2016-07-06 22:19:33]

CQ bit was unchecked.