Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: tracing/tracing/value/ui/value_set_view.html

Issue 2117913002: value-set-view must select the 0th tab even if it is the only one (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: test value-set-view Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/value_set_table.html ('k') | tracing/tracing/value/ui/value_set_view_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/value_set_view.html
diff --git a/tracing/tracing/value/ui/value_set_view.html b/tracing/tracing/value/ui/value_set_view.html
index 9a773957e749cf27222fc4ce8b2318baaa682f56..996d96b8cc152d901262d1d80e904a0a9dcbe682 100644
--- a/tracing/tracing/value/ui/value_set_view.html
+++ b/tracing/tracing/value/ui/value_set_view.html
@@ -16,7 +16,7 @@ found in the LICENSE file.
<script>
'use strict';
-tr.exportTo('tr.ui', function() {
+tr.exportTo('tr.v.ui', function() {
var VALUE_SET_VIEW_ELEMENT_NAMES = [];
var SELECTED_TAB_SETTINGS_KEY = 'tr-v-ui-value-set-view-element-name';
@@ -62,7 +62,8 @@ tr.exportTo('tr.ui', function() {
if (this.$.container.children.length === 1) {
this.$.container.tabsHidden = true;
- } else if (this.$.container.selectedTab === undefined) {
+ }
+ if (this.$.container.selectedTab === undefined) {
this.$.container.children[0].setAttribute('selected', true);
}
}
@@ -81,7 +82,8 @@ tr.exportTo('tr.ui', function() {
}
return {
- registerValueSetView: registerValueSetView
+ registerValueSetView: registerValueSetView,
+ SELECTED_TAB_SETTINGS_KEY: SELECTED_TAB_SETTINGS_KEY
};
});
</script>
« no previous file with comments | « tracing/tracing/value/ui/value_set_table.html ('k') | tracing/tracing/value/ui/value_set_view_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698