Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2117903002: printing: Adjust deprecation warning flag. (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, skau
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

printing: Adjust deprecation warning flag. The printing team plans to migrate to newer CUPS APIs once older Linux versions (which have old CUPS versions) are no longer supported. With newer OS X deployment targets, the current CUPS APIs are marked deprecated. There was already a flag to suppress these warnings, but it was added only when using a 10.9 SDK, which we haven't used in quite a while. (In general, deprecation warnings should be fixed, not suppressed. But in this case, printing team has a plan for fixing them, and they want to use one code base for both Linux and macOS.) BUG=622493 Committed: https://crrev.com/6bbe18d826106ca9b6a96a26b6341ad2899f60d3 Cr-Commit-Position: refs/heads/master@{#403539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M printing/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M printing/printing.gyp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
thestig, skau: Did I get your intention correctly from that bug?
4 years, 5 months ago (2016-07-01 20:36:25 UTC) #2
Lei Zhang
lgtm We'll get there eventually.
4 years, 5 months ago (2016-07-01 21:31:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117903002/1
4 years, 5 months ago (2016-07-01 21:34:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 21:39:31 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 21:39:34 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 21:42:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bbe18d826106ca9b6a96a26b6341ad2899f60d3
Cr-Commit-Position: refs/heads/master@{#403539}

Powered by Google App Engine
This is Rietveld 408576698