Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: printing/printing.gyp

Issue 2117903002: printing: Adjust deprecation warning flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing.gyp
diff --git a/printing/printing.gyp b/printing/printing.gyp
index 6e5c06d63c5e2d0512cddbca697ad0aed1e71333..be202cbfdb838df6337f342c91c59be37cda7058 100644
--- a/printing/printing.gyp
+++ b/printing/printing.gyp
@@ -152,13 +152,16 @@
# below.
],
}],
- ['OS=="mac" and mac_sdk=="10.9"', {
+ ['OS=="mac"', {
# The 10.9 SDK includes cups 1.7, which deprecates
# httpConnectEncrypt() in favor of httpConnect2(). hhttpConnect2()
# is new in 1.7, so it doesn't exist on OS X 10.6-10.8 and we
# can't use it until 10.9 is our minimum system version.
# (cups_version isn't reliable on OS X, so key the check off of
# mac_sdk).
+ # With a 10.8 deployment target, several other APIs are
+ # deprecated. We're still on CUPS 1.4 until Linux no longer
+ # needs to support it, see comment above.
'xcode_settings': {
'WARNING_CFLAGS': [
'-Wno-deprecated-declarations',
« no previous file with comments | « printing/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698