Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2117763004: Revert of Enable public key pinning of local trust anchors (Closed)

Created:
4 years, 5 months ago by kelvinp
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable public key pinning of local trust anchors (patchset #5 id:80001 of https://codereview.chromium.org/2052363002/ ) Reason for revert: Android Bot Compilation failure: ../../components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java:196: error: method createMockCertVerifier in class MockCertVerifier cannot be applied to given types; https://build.chromium.org/p/chromium/builders/Android/builds/58499/steps/compile/logs/stdio Original issue's description: > Enable public key pinning of local trust anchors > > Provides a new API that allows Cronet client to enable public key pinning of local trust anchors, i.e. pinning of certificates added to the local user trust store. > > /** > * Enables or disables pinning of the local (user-level) trust anchors. > * > * @param value {@code true} to enable pinning, {@code false} to disable. > * @return the builder to facilitate chaining. > */ > public Builder enablePublicKeyPinsForLocalTrustAnchors(boolean value); > > BUG=606832 > > Committed: https://crrev.com/9cf8e6f923a9b472c8b3521d52b3b6ca910f77cf > Cr-Commit-Position: refs/heads/master@{#403486} TBR=rsleevi@chromium.org,mef@chromium.org,xunjieli@chromium.org,kapishnikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606832 Committed: https://crrev.com/025788d30fdf38744ebe718d8d8ecd5da161f8a9 Cr-Commit-Position: refs/heads/master@{#403498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -154 lines) Patch
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 3 chunks +1 line, -25 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java View 2 chunks +2 lines, -4 lines 0 comments Download
M components/cronet/android/test/cronet_url_request_context_config_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java View 17 chunks +12 lines, -71 lines 0 comments Download
M components/cronet/android/test/mock_cert_verifier.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java View 1 chunk +3 lines, -4 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/QuicTestServer.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/url_request_context_config.h View 2 chunks +1 line, -6 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M net/http/transport_security_state.h View 2 chunks +0 lines, -11 lines 0 comments Download
M net/http/transport_security_state.cc View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kelvinp
Created Revert of Enable public key pinning of local trust anchors
4 years, 5 months ago (2016-07-01 19:21:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117763004/1
4 years, 5 months ago (2016-07-01 19:21:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 19:22:49 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 19:24:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/025788d30fdf38744ebe718d8d8ecd5da161f8a9
Cr-Commit-Position: refs/heads/master@{#403498}

Powered by Google App Engine
This is Rietveld 408576698