components/cronet/url_request_context_config.h - Issue 2117763004: Revert of Enable public key pinning of local trust anchors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/url_request_context_config.h

Issue 2117763004: Revert of Enable public key pinning of local trust anchors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/src/org/chromium/net/QuicTestServer.java ('k') | components/cronet/url_request_context_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/url_request_context_config.h

diff --git a/components/cronet/url_request_context_config.h b/components/cronet/url_request_context_config.h

index 2a00cf12a05201ebb286c0489c05b0c3c8bc1b4d..f464dbbc5cfbbee6acc4b0171568aa1240d4fcd2 100644

--- a/components/cronet/url_request_context_config.h

+++ b/components/cronet/url_request_context_config.h

@@ -109,9 +109,7 @@

// MockCertVerifier to use for testing purposes.

std::unique_ptr<net::CertVerifier> mock_cert_verifier,

// Enable network quality estimator.

- bool enable_network_quality_estimator,

- // Enable bypassing of public key pinning for local trust anchors

- bool bypass_public_key_pinning_for_local_trust_anchors);

+ bool enable_network_quality_estimator);

~URLRequestContextConfig();

// Configure |context_builder| based on |this|.

@@ -158,9 +156,6 @@

// Enable network quality estimator.

const bool enable_network_quality_estimator;

- // Enable public key pinning bypass for local trust anchors.

- const bool bypass_public_key_pinning_for_local_trust_anchors;

// App-provided list of servers that support QUIC.

ScopedVector<QuicHint> quic_hints;