Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2117643002: Revert of Reland "Build delegation for perf tryjobs" (Closed)

Created:
4 years, 5 months ago by RobertoCN
Modified:
4 years, 5 months ago
Reviewers:
Ziqi Xiong
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Reland "Build delegation for perf tryjobs" (patchset #2 id:10001 of https://codereview.chromium.org/2113033002/ ) Reason for revert: There is a problem with the build request's formatting. The field `buildername` should be called `builder_name` Please fix this and re-land Original issue's description: > Reland issue: https://codereview.chromium.org/2103133005/ > > In original issue, build_state.is_completed is checking for stdout['status'] instead of > stdout['build']['status'] > > BUG= > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/c62890265b947bf33fe45001298f3522ae205a01 TBR=zxiong@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/0db2df22229dde5d9cf3406115b77b5b5f2a158c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6587 lines, -8320 lines) Patch
M scripts/slave/recipe_modules/perf_try/__init__.py View 2 chunks +0 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/perf_try/api.py View 4 chunks +7 lines, -153 lines 0 comments Download
D scripts/slave/recipe_modules/perf_try/build_state.py View 1 chunk +0 lines, -54 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 6 chunks +26 lines, -113 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus6_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus7_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus9_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_one_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_cq.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_webview_arm64_aosp_perf_bisect.json View 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 9 chunks +124 lines, -209 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 8 chunks +151 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 10 chunks +204 lines, -117 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.py View 5 chunks +7 lines, -93 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 8 chunks +109 lines, -181 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 8 chunks +109 lines, -181 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 7 chunks +120 lines, -151 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json View 8 chunks +109 lines, -181 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
RobertoCN
Created Revert of Reland "Build delegation for perf tryjobs"
4 years, 5 months ago (2016-06-30 23:19:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117643002/1
4 years, 5 months ago (2016-06-30 23:19:17 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:19:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/0db2df22229dde5d9cf3...

Powered by Google App Engine
This is Rietveld 408576698