Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2117613002: Milo: Add step text for swarming task exceptions (Closed)

Created:
4 years, 5 months ago by Ryan Tseng
Modified:
4 years, 5 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Add step text for swarming task exceptions BUG=615547 Committed: https://github.com/luci/luci-go/commit/67f58aee28eded6453df792fc5bdb03cbda809e6

Patch Set 1 #

Patch Set 2 : Tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M appengine/cmd/milo/swarming/build.go View 1 chunk +9 lines, -0 lines 0 comments Download
M appengine/cmd/milo/swarming/build_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download
A + appengine/cmd/milo/swarming/expectations/build-canceled.json View 1 3 chunks +4 lines, -6 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-timeout.json View 1 chunk +3 lines, -1 line 0 comments Download
A + appengine/cmd/milo/swarming/testdata/build-canceled View 1 0 chunks +-1 lines, --1 lines 1 comment Download
A + appengine/cmd/milo/swarming/testdata/build-canceled.swarm View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117613002/1
4 years, 5 months ago (2016-06-30 22:06:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117613002/20001
4 years, 5 months ago (2016-06-30 22:10:19 UTC) #4
Ryan Tseng
ptal https://codereview.chromium.org/2117613002/diff/20001/appengine/cmd/milo/swarming/testdata/build-canceled File appengine/cmd/milo/swarming/testdata/build-canceled (right): https://codereview.chromium.org/2117613002/diff/20001/appengine/cmd/milo/swarming/testdata/build-canceled#newcode1 appengine/cmd/milo/swarming/testdata/build-canceled:1: @@@CURRENT_TIMESTAMP@1457949601@@@ This is reused from build-timeout, with one ...
4 years, 5 months ago (2016-06-30 22:11:49 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 22:20:34 UTC) #8
nodir
lgtm
4 years, 5 months ago (2016-06-30 22:30:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117613002/20001
4 years, 5 months ago (2016-06-30 22:35:18 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 22:38:55 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/67f58aee28eded6453df792fc5bdb03cbda809e6

Powered by Google App Engine
This is Rietveld 408576698