appengine/cmd/milo/swarming/build.go - Issue 2117613002: Milo: Add step text for swarming task exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/milo/swarming/build.go

Issue 2117613002: Milo: Add step text for swarming task exceptions (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/cmd/milo/swarming/build.go

diff --git a/appengine/cmd/milo/swarming/build.go b/appengine/cmd/milo/swarming/build.go

index 69946cf877d433ab57d10ea30c0389d38a368112..0b144f3af6fec92e653dbb2375e8dba3c32dc6aa 100644

--- a/appengine/cmd/milo/swarming/build.go

+++ b/appengine/cmd/milo/swarming/build.go

@@ -219,10 +219,19 @@ func taskToBuild(c context.Context, server string, sr *swarming.SwarmingRpcsTask

case TaskExpired, TaskTimedOut, TaskBotDied:

build.Summary.Status = resp.InfraFailure

+ switch sr.State {

+ case TaskExpired:

+ build.Summary.Text = append(build.Summary.Text, "Task expired")

+ case TaskTimedOut:

+ build.Summary.Text = append(build.Summary.Text, "Task timed out")

+ case TaskBotDied:

+ build.Summary.Text = append(build.Summary.Text, "Bot died")

+ }

case TaskCanceled:

// Cancelled build is user action, so it is not an infra failure.

build.Summary.Status = resp.Failure

+ build.Summary.Text = append(build.Summary.Text, "Task cancelled by user")

case TaskCompleted:

« no previous file with comments | « no previous file | appengine/cmd/milo/swarming/build_test.go » ('j') | appengine/cmd/milo/swarming/testdata/build-canceled » ('J')