third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2117543003: [InputEvent] Fill |data| field for 'input' event InsertText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2117543003: [InputEvent] Fill |data| field for 'input' event InsertText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests for InputEvent.data Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/Editor.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h » ('j') | third_party/WebKit/Source/core/editing/commands/TypingCommand.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index c0d9030727ba5011dc26aa0840f4266a819d1eea..9dfb372162f6a100c0f5327f4b10477ce4636c8c 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -236,6 +236,11 @@ bool CompositeEditCommand::isTypingCommand() const

return false;

}

+bool CompositeEditCommand::isInsertTextCommand() const

+ return false;

bool CompositeEditCommand::isReplaceSelectionCommand() const

{

return false;