third_party/WebKit/Source/core/editing/commands/TypingCommand.h - Issue 2117543003: [InputEvent] Fill |data| field for 'input' event InsertText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

Issue 2117543003: [InputEvent] Fill |data| field for 'input' event InsertText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests for InputEvent.data Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/Editor.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

index 7eb723f149dfcef20662bb7d21ca21d9e97a25e3..600d9375b34786445104cec78f2907e4eb2c8600 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

@@ -79,6 +79,8 @@ public:

ETypingCommand commandTypeOfOpenCommand() const { return m_commandType; }

TextCompositionType compositionType() const { return m_compositionType; }

+ // TyingCommand may contain multiple InsertTextCommand, |textOfLastCommand()| returns the text of the last one.

yosin_UTC9 2016/07/05 01:22:07 s/Tying/Typing/

chongz 2016/07/05 20:33:27 Done.

+ String textOfLastCommand() const;

private:

static TypingCommand* create(Document& document, ETypingCommand command, const String& text = "", Options options = 0, TextGranularity granularity = CharacterGranularity)