More extensive error handling for 'unresolved' cases.

More extensive error handling for 'unresolved' cases.

Rasta now has its own Accessors with proper error handling.
They are currently only used for unresolved cases. There is
a corresponding CL to kernel with some changes to accessors
to allow this.

There seem to be some bits of information missing for quality
error messages in some cases, like, for 'unresolvedGet' it
is not clear if the getter should be a top-level getter,
or static class getter, or something else.

R=ahe@google.com

Committed: https://github.com/dart-lang/rasta/commit/60a12d7a5c0c0689d35a79d1ff174e640a28d7fb

[asgerf, 2016-06-30 16:04:49]

Description was changed from

==========
More extensive error handling for `unresolvedXXX` cases.
==========

to

==========
More extensive error handling for `unresolve` cases.
==========

[asgerf, 2016-06-30 16:13:20]

Description was changed from

==========
More extensive error handling for `unresolve` cases.
==========

to

==========
More extensive error handling for 'unresolved' cases.

Rasta now has its own Accessors with proper error handling.
They are currently only used for unresolved cases. There is
a corresponding CL to kernel with some changes to accessors
to allow this.

There seem to be some bits of information missing for quality
error messages in some cases, like, for 'unresolvedGet' it
is not clear if the getter should be a top-level getter,
or static class getter, or something else.
==========

[asgerf, 2016-06-30 16:16:55]

asgerf@google.com changed reviewers:
+ ahe@google.com, kasperl@google.com

[ahe, 2016-07-01 08:48:40]

lgtm

https://codereview.chromium.org/2117513002/diff/20001/dart_vm_standalone/rast...
File dart_vm_standalone/rasta_errors.dart (right):

https://codereview.chromium.org/2117513002/diff/20001/dart_vm_standalone/rast...
dart_vm_standalone/rasta_errors.dart:180: return new NoSuchMethodError(receiver,
methodName, arguments, namedArguments, existingArgumentNames);
Long line.

[asgerf, 2016-07-01 09:32:25]

https://codereview.chromium.org/2117513002/diff/20001/dart_vm_standalone/rast...
File dart_vm_standalone/rasta_errors.dart (right):

https://codereview.chromium.org/2117513002/diff/20001/dart_vm_standalone/rast...
dart_vm_standalone/rasta_errors.dart:180: return new NoSuchMethodError(receiver,
methodName, arguments, namedArguments, existingArgumentNames);
On 2016/07/01 08:48:39, ahe wrote:
> Long line.

Done.

[asgerf, 2016-07-01 10:06:39]

Description was changed from

==========
More extensive error handling for 'unresolved' cases.

Rasta now has its own Accessors with proper error handling.
They are currently only used for unresolved cases. There is
a corresponding CL to kernel with some changes to accessors
to allow this.

There seem to be some bits of information missing for quality
error messages in some cases, like, for 'unresolvedGet' it
is not clear if the getter should be a top-level getter,
or static class getter, or something else.
==========

to

==========
More extensive error handling for 'unresolved' cases.

Rasta now has its own Accessors with proper error handling.
They are currently only used for unresolved cases. There is
a corresponding CL to kernel with some changes to accessors
to allow this.

There seem to be some bits of information missing for quality
error messages in some cases, like, for 'unresolvedGet' it
is not clear if the getter should be a top-level getter,
or static class getter, or something else.

R=ahe@google.com

Committed:
https://github.com/dart-lang/rasta/commit/60a12d7a5c0c0689d35a79d1ff174e640a2...
==========

[asgerf, 2016-07-01 10:06:41]

Committed patchset #6 (id:100001) manually as
60a12d7a5c0c0689d35a79d1ff174e640a28d7fb (presubmit successful).