chrome/renderer/searchbox/searchbox.h - Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup

Patch Set: TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/ntp_logging_events.h ('K') | « chrome/common/render_messages.h ('k') | chrome/renderer/searchbox/searchbox.cc » ('j') | chrome/renderer/searchbox/searchbox_extension.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/searchbox/searchbox.h

diff --git a/chrome/renderer/searchbox/searchbox.h b/chrome/renderer/searchbox/searchbox.h

index b3eb8d35b0de6248c4ca5899307a1fe1cade5dba..fe9674eed290a12b3dfba6f3dd0c5908f589a16e 100644

--- a/chrome/renderer/searchbox/searchbox.h

+++ b/chrome/renderer/searchbox/searchbox.h

@@ -54,10 +54,10 @@ class SearchBox : public content::RenderViewObserver,

void LogEvent(NTPLoggingEventType event);

// Sends ChromeViewHostMsg_LogMostVisitedImpression to the browser.

- void LogMostVisitedImpression(int position, const base::string16& provider);

+ void LogMostVisitedImpression(int position, NTPLoggingTileSource tile_source);

// Sends ChromeViewHostMsg_LogMostVisitedNavigation to the browser.

- void LogMostVisitedNavigation(int position, const base::string16& provider);

+ void LogMostVisitedNavigation(int position, NTPLoggingTileSource tile_source);

// Sends ChromeViewHostMsg_ChromeIdentityCheck to the browser.

void CheckIsUserSignedInToChromeAs(const base::string16& identity);

« chrome/common/ntp_logging_events.h ('K') | « chrome/common/render_messages.h ('k') | chrome/renderer/searchbox/searchbox.cc » ('j') | chrome/renderer/searchbox/searchbox_extension.cc » ('J')