Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/renderer/searchbox/searchbox.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup
Patch Set: TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_ 5 #ifndef CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_
6 #define CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_ 6 #define CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 const = 0; 47 const = 0;
48 }; 48 };
49 49
50 explicit SearchBox(content::RenderView* render_view); 50 explicit SearchBox(content::RenderView* render_view);
51 ~SearchBox() override; 51 ~SearchBox() override;
52 52
53 // Sends ChromeViewHostMsg_LogEvent to the browser. 53 // Sends ChromeViewHostMsg_LogEvent to the browser.
54 void LogEvent(NTPLoggingEventType event); 54 void LogEvent(NTPLoggingEventType event);
55 55
56 // Sends ChromeViewHostMsg_LogMostVisitedImpression to the browser. 56 // Sends ChromeViewHostMsg_LogMostVisitedImpression to the browser.
57 void LogMostVisitedImpression(int position, const base::string16& provider); 57 void LogMostVisitedImpression(int position, NTPLoggingTileSource tile_source);
58 58
59 // Sends ChromeViewHostMsg_LogMostVisitedNavigation to the browser. 59 // Sends ChromeViewHostMsg_LogMostVisitedNavigation to the browser.
60 void LogMostVisitedNavigation(int position, const base::string16& provider); 60 void LogMostVisitedNavigation(int position, NTPLoggingTileSource tile_source);
61 61
62 // Sends ChromeViewHostMsg_ChromeIdentityCheck to the browser. 62 // Sends ChromeViewHostMsg_ChromeIdentityCheck to the browser.
63 void CheckIsUserSignedInToChromeAs(const base::string16& identity); 63 void CheckIsUserSignedInToChromeAs(const base::string16& identity);
64 64
65 // Sends ChromeViewHostMsg_HistorySyncCheck to the browser. 65 // Sends ChromeViewHostMsg_HistorySyncCheck to the browser.
66 void CheckIsUserSyncingHistory(); 66 void CheckIsUserSyncingHistory();
67 67
68 // Sends ChromeViewHostMsg_SearchBoxDeleteMostVisitedItem to the browser. 68 // Sends ChromeViewHostMsg_SearchBoxDeleteMostVisitedItem to the browser.
69 void DeleteMostVisitedItem(InstantRestrictedID most_visited_item_id); 69 void DeleteMostVisitedItem(InstantRestrictedID most_visited_item_id);
70 70
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 InstantRestrictedIDCache<InstantMostVisitedItem> most_visited_items_cache_; 177 InstantRestrictedIDCache<InstantMostVisitedItem> most_visited_items_cache_;
178 ThemeBackgroundInfo theme_info_; 178 ThemeBackgroundInfo theme_info_;
179 base::string16 query_; 179 base::string16 query_;
180 EmbeddedSearchRequestParams embedded_search_request_params_; 180 EmbeddedSearchRequestParams embedded_search_request_params_;
181 InstantSuggestion suggestion_; 181 InstantSuggestion suggestion_;
182 182
183 DISALLOW_COPY_AND_ASSIGN(SearchBox); 183 DISALLOW_COPY_AND_ASSIGN(SearchBox);
184 }; 184 };
185 185
186 #endif // CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_ 186 #endif // CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698