chrome/common/render_messages.h - Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/render_messages.h

Issue 2117373002: Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp_uma_cleanup

Patch Set: TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/ntp_logging_events.h ('K') | « chrome/common/ntp_logging_events.h ('k') | chrome/renderer/searchbox/searchbox.h » ('j') | chrome/renderer/searchbox/searchbox_extension.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/render_messages.h

diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h

index 7f6b638e5965e87460e0d6512017263e195a6f9f..d1eb0615c54263440b9593b398f0879ac264acba 100644

--- a/chrome/common/render_messages.h

+++ b/chrome/common/render_messages.h

@@ -165,6 +165,9 @@ IPC_STRUCT_TRAITS_END()

IPC_ENUM_TRAITS_MAX_VALUE(NTPLoggingEventType,

NTP_EVENT_TYPE_LAST)

+IPC_ENUM_TRAITS_MAX_VALUE(NTPLoggingTileSource,

+ NTP_TILE_SOURCE_LAST)

IPC_ENUM_TRAITS_MAX_VALUE(WebApplicationInfo::MobileCapable,

WebApplicationInfo::MOBILE_CAPABLE_APPLE)

@@ -488,14 +491,14 @@ IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogEvent,

IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogMostVisitedImpression,

int /* page_seq_no */,

int /* position */,

- base::string16 /* provider */)

+ NTPLoggingTileSource /* tile_source */)

// Logs a navigation on one of the Most Visited tile on the InstantExtended

// New Tab Page.

IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogMostVisitedNavigation,

int /* page_seq_no */,

int /* position */,

- base::string16 /* provider */)

+ NTPLoggingTileSource /* tile_source */)

// The Instant page asks whether the user syncs its history.

IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_HistorySyncCheck,

« chrome/common/ntp_logging_events.h ('K') | « chrome/common/ntp_logging_events.h ('k') | chrome/renderer/searchbox/searchbox.h » ('j') | chrome/renderer/searchbox/searchbox_extension.cc » ('J')