Issue 211733007: clang roll 198389:202554 revolutions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211733007: clang roll 198389:202554 revolutions (Closed)

Created:
6 years, 9 months ago by Nico

Modified:
6 years, 9 months ago

Reviewers:
hans

CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

clang roll 198389:202554 revolutions First try: https://codereview.chromium.org/195623002 Second try: https://codereview.chromium.org/211213004 Difference from "second try" is passing --enable-libedit=no to configure, to not depend on libedit.3.dylib (which doesn't exist on OS X 10.6), see diff from patch set 1 to 2. The linux package wasn't rebuilt, so it's configured without that flag. That shouldn't cause issues hopefully. BUG=351479, 287029, 341352, 333968, 335325 R=hans@chromium.org TBR=hans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259411

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+715 lines, -21 lines)			Patch
M	build/common.gypi	View		4 chunks	+7 lines, -1 line	0 comments	Download
M	build/config/compiler/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/libxml/libxml.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/clang/blink_gc_plugin/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/clang/plugins/ChromeClassTester.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	tools/clang/scripts/package.sh	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/clang/scripts/plugin_flags.sh	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	tools/clang/scripts/update.sh	View	1	5 chunks	+697 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Nico

6 years, 9 months ago (2014-03-26 00:14:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r259411 (presubmit successful).