Allow VM precompiled to pass trailing-comma test.

Allow VM precompiled to pass trailing-comma test.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/3459d414723b97e27a890c582e90617037f7c1bb

[Lasse Reichstein Nielsen, 2016-07-05 08:19:09]

lrn@google.com changed reviewers:
+ floitsch@google.com

[Lasse Reichstein Nielsen, 2016-07-05 08:19:09]

https://codereview.chromium.org/2117293002/diff/1/tests/language/arg_param_tr...
File tests/language/arg_param_trailing_comma_test.dart (left):

https://codereview.chromium.org/2117293002/diff/1/tests/language/arg_param_tr...
tests/language/arg_param_trailing_comma_test.dart:79: args,                     
                       /// main_with_trailing
It's not an important test, mainly a curiosity, so I think it's safer to just
drop the argument. It's not worth the complication.

[Lasse Reichstein Nielsen, 2016-07-05 08:43:17]

lrn@google.com changed reviewers:
+ whesse@google.com

[Lasse Reichstein Nielsen, 2016-07-05 08:43:18]

+Bill

[Bill Hesse, 2016-07-05 08:48:01]

lgtm

LGTM

I already have a CL out for this: https://codereview.chromium.org/2125563002/

Do you prefer changing the test?  If so, comment on what needs changed in my CL.

[Bill Hesse, 2016-07-05 08:58:36]

I landed my CL first, so this needs to be rebased.

[Bill Hesse, 2016-07-05 09:18:56]

On 2016/07/05 08:58:36, Bill Hesse wrote:
> I landed my CL first, so this needs to be rebased.

My CL broke the VM status, but yours removes the section with [ $compiler ==
none || $runtime == dartium && $runtime == drt ] which seems to be a broken
logical expression, and will fix things.

I read that as compiler == none && (runtime == dartium || runtime == drt), which
is probably what was intended, so I broke things.  But when you remove it, they
will be fixed.

[Lasse Reichstein Nielsen, 2016-07-05 09:25:14]

Description was changed from

==========
Allow VM precompiled to pass trailing-comma test.
==========

to

==========
Allow VM precompiled to pass trailing-comma test.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3459d414723b97e27a890c582e90617037f7c1bb
==========

[Lasse Reichstein Nielsen, 2016-07-05 09:25:15]

Committed patchset #1 (id:1) manually as
3459d414723b97e27a890c582e90617037f7c1bb (presubmit successful).