Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: tests/language/language.status

Issue 2117293002: Allow VM precompiled to pass trailing-comma test. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/language.status
diff --git a/tests/language/language.status b/tests/language/language.status
index 67520f990315a27e11e3fbaa21717b68caada6f3..03fd476165f6a284f9c08aae879297d4f7d36bcf 100644
--- a/tests/language/language.status
+++ b/tests/language/language.status
@@ -5,12 +5,12 @@
# This directory contains tests that are intended to show the
# current state of the language.
-[ $compiler != none || ($runtime != vm && $runtime != dartium && $runtime != drt)]
+# Trailing commas are so far supported by:
+# - The VM (vm, dartium, drt, precompiler+dart_precompiled)
+# Remaining targets still fail on arg_param_trailing_comma_test/none.
+[($compiler != none && $compiler != precompiler) || ($runtime != vm && $runtime != dartium && $runtime != drt && $runtime != dart_precompiled)]
arg_param_trailing_comma_test/none: Fail # Issue 26644
-[ $compiler == none || $runtime == dartium && $runtime == drt ]
-arg_param_trailing_comma_test/main_with_trailing: Fail, OK # Dartium only looks for main without args.
-
[ ($compiler == none || $compiler == precompiler || $compiler == dart2app || $compiler == dart2appjit) ]
tearoff_constructor_basic_test: Skip # Crashes in checked mode -- hausner investigating

Powered by Google App Engine
This is Rietveld 408576698