Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2117173002: cc: Don't skip clip rect calculation for copy request layers (Closed)

Created:
4 years, 5 months ago by weiliangc
Modified:
4 years, 5 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, enne (OOO), jaydasika
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Don't skip clip rect calculation for copy request layers When a layer with copy request is SetMasksToBounds, it is considered clipped, but the clip rect calculation is skipped, thus resulting in empty clip rect. This CL fixes this case. In production this case was never hit because for root layers we don't care about clip rect, and for non root copy request we don't SetMasksToBounds. BUG= R=ajuma CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e22ce84b3122197a719777d502f0c7e33dfea8cd Cr-Commit-Position: refs/heads/master@{#403723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M cc/trees/draw_property_utils.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
weiliangc
4 years, 5 months ago (2016-07-04 21:54:28 UTC) #2
ajuma
lgtm
4 years, 5 months ago (2016-07-04 23:03:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117173002/1
4 years, 5 months ago (2016-07-04 23:03:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 23:32:09 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 23:34:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e22ce84b3122197a719777d502f0c7e33dfea8cd
Cr-Commit-Position: refs/heads/master@{#403723}

Powered by Google App Engine
This is Rietveld 408576698