Issue 2117009: Fix a pref test -- Win/Linux don't have browser.show_page_options_buttons pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2117009: Fix a pref test -- Win/Linux don't have browser.show_page_options_buttons pref (Closed)

Created:
10 years, 7 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews

Visibility:
Public.

Description

Fix a pref test -- Win/Linux don't have browser.show_page_options_buttons pref TEST=python chrome/test/functional/prefs.py prefs.PrefsTest.testToolbarButtonsPref Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47481

Patch Set 1 #

Patch Set 2 : -omnibox #

Total comments: 4

Patch Set 3 : plat identification #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	chrome/test/functional/prefs.py	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download
	M	chrome/test/pyautolib/pyauto.py	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

LGTM for now, but... http://codereview.chromium.org/2117009/diff/2001/3001 File chrome/test/functional/prefs.py (right): http://codereview.chromium.org/2117009/diff/2001/3001#newcode112 chrome/test/functional/prefs.py:112: is_mac = sys.platform == 'darwin' ...

10 years, 7 months ago (2010-05-18 00:31:43 UTC) #2

Nirnimesh

10 years, 7 months ago (2010-05-18 00:55:07 UTC) #3

http://codereview.chromium.org/2117009/diff/2001/3001
File chrome/test/functional/prefs.py (right):

http://codereview.chromium.org/2117009/diff/2001/3001#newcode112
chrome/test/functional/prefs.py:112: is_mac = sys.platform == 'darwin'
On 2010/05/18 00:31:44, John Grabowski wrote:
> Perhaps now's a good time to add
> def IsMac():
>   return sys.platform == 'darwin'
> def IsLinux():
>   ...
> def IsPosix():
>   return IsMac() or IsLinux()
> def IsWin():
>   ...
> 

Done.

http://codereview.chromium.org/2117009/diff/2001/3001#newcode115
chrome/test/functional/prefs.py:115: if is_mac:  # win/linux don't have
"browser.show_page_options_buttons" pref
On 2010/05/18 00:31:44, John Grabowski wrote:
> Long term, what's the right answer?
> Add the pref to those platforms?
> Switch this test to use a different pref?
> 

I meant that win/linux chrome don't have an option to hide/show that button, so
there's no point in testing it. Mac does.

Expand Messages | Collapse Messages