Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3150)

Unified Diff: chrome/test/functional/prefs.py

Issue 2117009: Fix a pref test -- Win/Linux don't have browser.show_page_options_buttons pref (Closed)
Patch Set: plat identification Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/pyautolib/pyauto.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/prefs.py
diff --git a/chrome/test/functional/prefs.py b/chrome/test/functional/prefs.py
index 3b788ee371f594bc5eaebfd09249ecbf3aaf43e3..39e00a49a30698bd1e24f4a9e280a9db6c536ae6 100644
--- a/chrome/test/functional/prefs.py
+++ b/chrome/test/functional/prefs.py
@@ -6,6 +6,7 @@
import logging
import os
import shutil
+import sys
import pyauto_functional # Must be imported before pyauto
import pyauto
@@ -109,12 +110,15 @@ class PrefsTest(pyauto.PyUITest):
"""Verify toolbar buttons prefs.."""
# Assert defaults first
self.assertFalse(self.GetPrefsInfo().Prefs(pyauto.kShowHomeButton))
- self.assertFalse(self.GetPrefsInfo().Prefs(pyauto.kShowPageOptionsButtons))
self.SetPrefs(pyauto.kShowHomeButton, True)
- self.SetPrefs(pyauto.kShowPageOptionsButtons, True)
+ if self.IsMac(): # win/linux don't have the
+ self.assertFalse( # "browser.show_page_options_buttons" pref
+ self.GetPrefsInfo().Prefs(pyauto.kShowPageOptionsButtons))
+ self.SetPrefs(pyauto.kShowPageOptionsButtons, True)
self.RestartBrowser(clear_profile=False)
self.assertTrue(self.GetPrefsInfo().Prefs(pyauto.kShowHomeButton))
- self.assertTrue(self.GetPrefsInfo().Prefs(pyauto.kShowPageOptionsButtons))
+ if self.IsMac():
+ self.assertTrue(self.GetPrefsInfo().Prefs(pyauto.kShowPageOptionsButtons))
def testHomepagePrefs(self):
"""Verify homepage prefs."""
« no previous file with comments | « no previous file | chrome/test/pyautolib/pyauto.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698