Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: net/tools/gdig/gdig.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/gdig/gdig.cc
diff --git a/net/tools/gdig/gdig.cc b/net/tools/gdig/gdig.cc
index f3d84e31b49a3bbd60f4b7160085c37134b4f0fe..17832fe67f0f17357db53d62a238e77f73d308e3 100644
--- a/net/tools/gdig/gdig.cc
+++ b/net/tools/gdig/gdig.cc
@@ -231,6 +231,7 @@ class GDig {
std::unique_ptr<FileNetLogObserver> log_observer_;
std::unique_ptr<NetLog> log_;
std::unique_ptr<HostResolver> resolver_;
+ std::unique_ptr<HostResolver::Request> request_;
#if defined(OS_MACOSX)
// Without this there will be a mem leak on osx.
@@ -468,11 +469,7 @@ void GDig::ReplayNextEntry() {
++active_resolves_;
++replay_log_index_;
int ret = resolver_->Resolve(
- info,
- DEFAULT_PRIORITY,
- addrlist,
- callback,
- NULL,
+ info, DEFAULT_PRIORITY, addrlist, callback, &request_,
BoundNetLog::Make(log_.get(), net::NetLog::SOURCE_NONE));
if (ret != ERR_IO_PENDING)
callback.Run(ret);
« net/proxy/proxy_resolver_v8_tracing.cc ('K') | « net/test/spawned_test_server/base_test_server.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698