Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: net/test/spawned_test_server/base_test_server.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/spawned_test_server/base_test_server.cc
diff --git a/net/test/spawned_test_server/base_test_server.cc b/net/test/spawned_test_server/base_test_server.cc
index cc29b3f403085467a86e27f4e0e8d506f0c2d404..d7dbf95fb2d7014eeae85d17c383a74b4ffd9a36 100644
--- a/net/test/spawned_test_server/base_test_server.cc
+++ b/net/test/spawned_test_server/base_test_server.cc
@@ -352,12 +352,9 @@ bool BaseTestServer::GetAddressList(AddressList* address_list) const {
// IPv6 literal hostnames.
info.set_address_family(ADDRESS_FAMILY_IPV4);
TestCompletionCallback callback;
- int rv = resolver->Resolve(info,
- DEFAULT_PRIORITY,
- address_list,
- callback.callback(),
- NULL,
- BoundNetLog());
+ std::unique_ptr<HostResolver::Request> request;
+ int rv = resolver->Resolve(info, DEFAULT_PRIORITY, address_list,
+ callback.callback(), &request, BoundNetLog());
if (rv == ERR_IO_PENDING)
rv = callback.WaitForResult();
if (rv != OK) {

Powered by Google App Engine
This is Rietveld 408576698