net/dns/single_request_host_resolver.h - Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/single_request_host_resolver.h

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/single_request_host_resolver.h

diff --git a/net/dns/single_request_host_resolver.h b/net/dns/single_request_host_resolver.h

index f2843093fc8ec1ba761cdd67938184180774b8e4..2c89e44ac1ae2d01ff69d7b751ee354434b76142 100644

--- a/net/dns/single_request_host_resolver.h

+++ b/net/dns/single_request_host_resolver.h

@@ -50,7 +50,7 @@ class NET_EXPORT SingleRequestHostResolver {

HostResolver* const resolver_;

// The current request (if any).

- HostResolver::RequestHandle cur_request_;

+ std::unique_ptr<HostResolver::Request> cur_request_;

CompletionCallback cur_request_callback_;

// Completion callback for when request to |resolver_| completes.

« no previous file with comments | « net/dns/mojo_host_resolver_impl_unittest.cc ('k') | net/dns/single_request_host_resolver.cc » ('j') | net/proxy/proxy_resolver_v8_tracing.cc » ('J')