Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: net/dns/mojo_host_resolver_impl_unittest.cc

Issue 2116983002: Change HostResolver::Resolve() to take an std::unique_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: http_stream_factory_impl_job_controller_unittest RequestHandle* to unique_ptr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/mojo_host_resolver_impl_unittest.cc
diff --git a/net/dns/mojo_host_resolver_impl_unittest.cc b/net/dns/mojo_host_resolver_impl_unittest.cc
index aac961735dab873dd189ccf3a8159075fb73c1cf..0ffb50db5a761a119d5f1301125651db0371c14a 100644
--- a/net/dns/mojo_host_resolver_impl_unittest.cc
+++ b/net/dns/mojo_host_resolver_impl_unittest.cc
@@ -105,7 +105,7 @@ class CallbackMockHostResolver : public MockHostResolver {
RequestPriority priority,
AddressList* addresses,
const CompletionCallback& callback,
- RequestHandle* out_req,
+ std::unique_ptr<Request>* request,
const BoundNetLog& net_log) override;
private:
@@ -116,10 +116,10 @@ int CallbackMockHostResolver::Resolve(const RequestInfo& info,
RequestPriority priority,
AddressList* addresses,
const CompletionCallback& callback,
- RequestHandle* out_req,
+ std::unique_ptr<Request>* request,
const BoundNetLog& net_log) {
int result = MockHostResolver::Resolve(info, priority, addresses, callback,
- out_req, net_log);
+ request, net_log);
if (!resolve_callback_.is_null()) {
resolve_callback_.Run();
resolve_callback_.Reset();

Powered by Google App Engine
This is Rietveld 408576698