Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2116903002: DevTools: do not detach sourcemap in case of style sheet editing (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not detach sourcemap in case of style sheet editing Also the sourcemapping does not make sense for the edited style sheet, it still seems to be helpful for the web developers as it gives a brief idea of source file name / approximate line number. This was regressed at crrev.com/1806233002 BUG=257778 R=dgozman Committed: https://crrev.com/2dfd4ba707f617a44641c4e732ec986a331b4618 Cr-Commit-Position: refs/heads/master@{#404316}

Patch Set 1 #

Messages

Total messages: 12 (5 generated)
lushnikov
please, take a look!
4 years, 5 months ago (2016-07-01 23:54:39 UTC) #1
dgozman
Can we have more detailed explanation why we do this? Also, if it was regressed, ...
4 years, 5 months ago (2016-07-05 18:14:33 UTC) #2
lushnikov
done, ptal
4 years, 5 months ago (2016-07-06 17:56:23 UTC) #5
dgozman
lgtm
4 years, 5 months ago (2016-07-06 21:32:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116903002/1
4 years, 5 months ago (2016-07-08 01:05:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 09:25:46 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:27:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dfd4ba707f617a44641c4e732ec986a331b4618
Cr-Commit-Position: refs/heads/master@{#404316}

Powered by Google App Engine
This is Rietveld 408576698