Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js

Issue 2116903002: DevTools: do not detach sourcemap in case of style sheet editing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-edit-property-after-invalid-rule.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
index dea9998afa2fcbc9dd41d24782161bb90da64b45..5ee2239f9615700c2a1fb7b2677414223d86c118 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
@@ -260,7 +260,7 @@ WebInspector.CSSModel.prototype = {
var originalAndDetach = originalAndDetachIfSuccess.bind(this, header);
if (!sourceMap.editable())
- return originalAndDetach();
+ return original();
return /** @type {!Promise<boolean>} */(sourceMap.editCompiled([range], [text])
.then(onEditingDone.bind(this))
@@ -418,7 +418,7 @@ WebInspector.CSSModel.prototype = {
return false;
this._domModel.markUndoableState();
var edit = new WebInspector.CSSModel.Edit(styleSheetId, range, text, selectorPayload);
- this._fireStyleSheetChangedAndDetach(styleSheetId, edit);
+ this._fireStyleSheetChanged(styleSheetId, edit);
return true;
}
@@ -448,7 +448,7 @@ WebInspector.CSSModel.prototype = {
return false;
this._domModel.markUndoableState();
var edit = new WebInspector.CSSModel.Edit(styleSheetId, range, text, payload);
- this._fireStyleSheetChangedAndDetach(styleSheetId, edit);
+ this._fireStyleSheetChanged(styleSheetId, edit);
return true;
}
@@ -682,7 +682,7 @@ WebInspector.CSSModel.prototype = {
return false;
this._domModel.markUndoableState();
var edit = new WebInspector.CSSModel.Edit(styleSheetId, range, newMediaText, mediaPayload);
- this._fireStyleSheetChangedAndDetach(styleSheetId, edit);
+ this._fireStyleSheetChanged(styleSheetId, edit);
return true;
}
@@ -716,7 +716,7 @@ WebInspector.CSSModel.prototype = {
return null;
this._domModel.markUndoableState();
var edit = new WebInspector.CSSModel.Edit(styleSheetId, ruleLocation, ruleText, rulePayload);
- this._fireStyleSheetChangedAndDetach(styleSheetId, edit);
+ this._fireStyleSheetChanged(styleSheetId, edit);
return new WebInspector.CSSStyleRule(this, rulePayload);
}
},
@@ -786,18 +786,6 @@ WebInspector.CSSModel.prototype = {
/**
* @param {!CSSAgent.StyleSheetId} styleSheetId
- * @param {!WebInspector.CSSModel.Edit=} edit
- */
- _fireStyleSheetChangedAndDetach: function(styleSheetId, edit)
- {
- this.dispatchEventToListeners(WebInspector.CSSModel.Events.StyleSheetChanged, { styleSheetId: styleSheetId, edit: edit });
- var header = this.styleSheetHeaderForId(styleSheetId);
- if (header)
- this._detachSourceMap(header);
- },
-
- /**
- * @param {!CSSAgent.StyleSheetId} styleSheetId
* @return {!Promise<string>}
*/
_ensureOriginalStyleSheetText: function(styleSheetId)
@@ -1096,7 +1084,7 @@ WebInspector.CSSDispatcher.prototype = {
*/
styleSheetChanged: function(styleSheetId)
{
- this._cssModel._fireStyleSheetChangedAndDetach(styleSheetId);
+ this._cssModel._fireStyleSheetChanged(styleSheetId);
},
/**
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-edit-property-after-invalid-rule.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698