Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2116723003: Simplify AA fill rect batch construction and rename Geometry->RectInfo (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@rectgeoms
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify AA fill rect batch construction and rename Geometry->RectInfo GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116723003 Committed: https://skia.googlesource.com/skia/+/0fdec8a0472c83eb0da1f8ee20b6531f0e7b2b1f

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -80 lines) Patch
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 11 chunks +65 lines, -80 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
bsalomon
4 years, 5 months ago (2016-07-01 04:01:57 UTC) #3
robertphillips
lgtm
4 years, 5 months ago (2016-07-01 12:15:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116723003/1
4 years, 5 months ago (2016-07-01 12:38:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/228269)
4 years, 5 months ago (2016-07-01 12:42:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116723003/1
4 years, 5 months ago (2016-07-01 13:05:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/4478) Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, ...
4 years, 5 months ago (2016-07-01 13:06:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116723003/20001
4 years, 5 months ago (2016-07-01 13:12:09 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 13:31:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0fdec8a0472c83eb0da1f8ee20b6531f0e7b2b1f

Powered by Google App Engine
This is Rietveld 408576698