Cleanup non-AA fill rect batch construction.

Cleanup non-AA fill rect batch construction.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119853002

Committed: https://skia.googlesource.com/skia/+/9d7f1849a88f5f2f6c7c00fe826d1d42a2df990f

[bsalomon, 2016-07-01 13:45:30]

Description was changed from

==========
Cleanup fill non AA batch construction.
==========

to

==========
Cleanup fill non AA batch construction.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119853002
==========

[bsalomon, 2016-07-01 13:47:31]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-07-01 13:47:59]

Description was changed from

==========
Cleanup fill non AA batch construction.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119853002
==========

to

==========
Cleanup non-AA fill rect batch construction.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119853002
==========

[bsalomon, 2016-07-01 13:48:07]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 13:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 14:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 14:06:49]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-01 14:14:16]

lgtm but I did like the asserts

https://codereview.chromium.org/2119853002/diff/20001/src/gpu/batches/GrNonAA...
File src/gpu/batches/GrNonAAFillRectBatch.cpp (right):

https://codereview.chromium.org/2119853002/diff/20001/src/gpu/batches/GrNonAA...
src/gpu/batches/GrNonAAFillRectBatch.cpp:96: : INHERITED(ClassID()) {
SkASSERT(!viewMatrix.hasPerspective() && (!localMatrix ||
!localMatrix->hasPerspective()));

?

https://codereview.chromium.org/2119853002/diff/20001/src/gpu/batches/GrNonAA...
src/gpu/batches/GrNonAAFillRectBatch.cpp:215: , fViewMatrix(viewMatrix) {
SkASSERT(viewMatrix.hasPerspective() || (localMatrix &&
localMatrix->hasPerspective())); 

?

[bsalomon, 2016-07-01 14:41:31]

https://codereview.chromium.org/2119853002/diff/20001/src/gpu/batches/GrNonAA...
File src/gpu/batches/GrNonAAFillRectBatch.cpp (right):

https://codereview.chromium.org/2119853002/diff/20001/src/gpu/batches/GrNonAA...
src/gpu/batches/GrNonAAFillRectBatch.cpp:96: : INHERITED(ClassID()) {
On 2016/07/01 14:14:16, robertphillips wrote:
> SkASSERT(!viewMatrix.hasPerspective() && (!localMatrix ||
> !localMatrix->hasPerspective()));
> 
> ?

Done.

https://codereview.chromium.org/2119853002/diff/20001/src/gpu/batches/GrNonAA...
src/gpu/batches/GrNonAAFillRectBatch.cpp:215: , fViewMatrix(viewMatrix) {
On 2016/07/01 14:14:16, robertphillips wrote:
> SkASSERT(viewMatrix.hasPerspective() || (localMatrix &&
> localMatrix->hasPerspective())); 
> 
> ?

Done.

[bsalomon, 2016-07-01 14:41:35]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-07-01 14:41:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2119853002/#ps60001
(title: "fix assert")

[commit-bot: I haz the power, 2016-07-01 14:41:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 15:01:39]

Description was changed from

==========
Cleanup non-AA fill rect batch construction.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119853002
==========

to

==========
Cleanup non-AA fill rect batch construction.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119853002

Committed:
https://skia.googlesource.com/skia/+/9d7f1849a88f5f2f6c7c00fe826d1d42a2df990f
==========

[commit-bot: I haz the power, 2016-07-01 15:01:41]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9d7f1849a88f5f2f6c7c00fe826d1d42a2df990f