third_party/WebKit/Source/core/paint/BoxClipper.cpp - Issue 2116693002: PaintChunk::id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxClipper.cpp

Issue 2116693002: PaintChunk::id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@CommitOnTheWay

Patch Set: Address chrishtr's comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/BoxClipper.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxClipper.cpp b/third_party/WebKit/Source/core/paint/BoxClipper.cpp

index 22e85f09d9a92cda519d725b288595655aee21c7..d5e5f37f7e9586e8d8444f78cbf816ddaccbc671 100644

--- a/third_party/WebKit/Source/core/paint/BoxClipper.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxClipper.cpp

@@ -30,7 +30,7 @@ BoxClipper::BoxClipper(const LayoutBox& box, const PaintInfo& paintInfo, const L

if (objectProperties && objectProperties->overflowClip()) {

PaintChunkProperties properties(paintInfo.context.getPaintController().currentPaintChunkProperties());

properties.clip = objectProperties->overflowClip();

- m_scopedClipProperty.emplace(paintInfo.context.getPaintController(), properties);

+ m_scopedClipProperty.emplace(paintInfo.context.getPaintController(), box, paintInfo.displayItemTypeForClipping(), properties);

}

return;

}