third_party/WebKit/Source/core/paint/BlockPainter.cpp - Issue 2116693002: PaintChunk::id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BlockPainter.cpp

Issue 2116693002: PaintChunk::id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@CommitOnTheWay

Patch Set: Address chrishtr's comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/paint/BoxClipper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/BlockPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/BlockPainter.cpp b/third_party/WebKit/Source/core/paint/BlockPainter.cpp

index 6bea9d3d4d49de5a249dfcb9d09a50bbe4c5875c..fa66c71a7862194010f8f023096b1696738dd5cd 100644

--- a/third_party/WebKit/Source/core/paint/BlockPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/BlockPainter.cpp

@@ -161,7 +161,7 @@ void BlockPainter::paintObject(const PaintInfo& paintInfo, const LayoutPoint& pa

if (auto* scrollTranslation = objectProperties ? objectProperties->scrollTranslation() : nullptr) {

PaintChunkProperties properties(paintInfo.context.getPaintController().currentPaintChunkProperties());

properties.transform = scrollTranslation;

- m_scopedScrollProperty.emplace(paintInfo.context.getPaintController(), properties);

+ m_scopedScrollProperty.emplace(paintInfo.context.getPaintController(), m_layoutBlock, DisplayItem::paintPhaseToDrawingType(paintPhase), properties);

scrolledPaintInfo.emplace(paintInfo);

scrolledPaintInfo->updateCullRect(scrollTranslation->matrix().toAffineTransform());

}