content/browser/appcache/appcache_url_request_job_unittest.cc - Issue 2116643002: Revert of Remove calls to MessageLoop::current() in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_url_request_job_unittest.cc

Issue 2116643002: Revert of Remove calls to MessageLoop::current() in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_storage_impl_unittest.cc ('k') | content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_url_request_job_unittest.cc

diff --git a/content/browser/appcache/appcache_url_request_job_unittest.cc b/content/browser/appcache/appcache_url_request_job_unittest.cc

index 8cde90b11a8452c32256c0192e8c1f9f35af8035..dbce38ddaf9a1c68a13b960d9fcca010e3bcf6e4 100644

--- a/content/browser/appcache/appcache_url_request_job_unittest.cc

+++ b/content/browser/appcache/appcache_url_request_job_unittest.cc

@@ -248,7 +248,7 @@

}

void SetUpTest() {

- DCHECK(io_thread_->task_runner()->BelongsToCurrentThread());

+ DCHECK(base::MessageLoop::current() == io_thread_->message_loop());

DCHECK(task_stack_.empty());

storage_delegate_.reset(new MockStorageDelegate(this));

@@ -268,7 +268,7 @@

}

void TearDownTest() {

- DCHECK(io_thread_->task_runner()->BelongsToCurrentThread());

+ DCHECK(base::MessageLoop::current() == io_thread_->message_loop());

request_.reset();

while (!task_stack_.empty())

@@ -292,7 +292,7 @@

void TestFinished() {

// We unwind the stack prior to finishing up to let stack

// based objects get deleted.

- DCHECK(io_thread_->task_runner()->BelongsToCurrentThread());

+ DCHECK(base::MessageLoop::current() == io_thread_->message_loop());

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::Bind(&AppCacheURLRequestJobTest::TestFinishedUnwound,

base::Unretained(this)));

@@ -312,7 +312,7 @@

}

void ScheduleNextTask() {

- DCHECK(io_thread_->task_runner()->BelongsToCurrentThread());

+ DCHECK(base::MessageLoop::current() == io_thread_->message_loop());

if (task_stack_.empty()) {

TestFinished();

return;