content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc - Issue 2116643002: Revert of Remove calls to MessageLoop::current() in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

Issue 2116643002: Revert of Remove calls to MessageLoop::current() in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_url_request_job_unittest.cc ('k') | content/browser/device_sensors/data_fetcher_shared_memory_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc b/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

index 50455960a9ec6c235061ad058ce7b5f0f3716385..73ce50242ad30baed55421c2237c5db375c6caf6 100644

--- a/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

+++ b/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

@@ -7,7 +7,6 @@

#include "base/logging.h"

#include "base/macros.h"

#include "base/process/process_handle.h"

-#include "base/single_thread_task_runner.h"

#include "base/synchronization/waitable_event.h"

#include "base/threading/thread.h"

#include "content/common/device_sensors/device_light_hardware_buffer.h"

@@ -274,8 +273,7 @@

~FakePollingDataFetcher() override {}

bool Start(ConsumerType consumer_type, void* buffer) override {

- EXPECT_TRUE(

- GetPollingMessageLoop()->task_runner()->BelongsToCurrentThread());

+ EXPECT_TRUE(base::MessageLoop::current() == GetPollingMessageLoop());

Init(consumer_type, buffer);

switch (consumer_type) {

@@ -298,8 +296,7 @@

}

bool Stop(ConsumerType consumer_type) override {

- EXPECT_TRUE(

- GetPollingMessageLoop()->task_runner()->BelongsToCurrentThread());

+ EXPECT_TRUE(base::MessageLoop::current() == GetPollingMessageLoop());

switch (consumer_type) {

case CONSUMER_TYPE_MOTION:

@@ -321,8 +318,7 @@

}

void Fetch(unsigned consumer_bitmask) override {

- EXPECT_TRUE(

- GetPollingMessageLoop()->task_runner()->BelongsToCurrentThread());

+ EXPECT_TRUE(base::MessageLoop::current() == GetPollingMessageLoop());

EXPECT_TRUE(consumer_bitmask & CONSUMER_TYPE_ORIENTATION ||

consumer_bitmask & CONSUMER_TYPE_ORIENTATION_ABSOLUTE ||

consumer_bitmask & CONSUMER_TYPE_MOTION ||

@@ -350,8 +346,7 @@

~FakeZeroDelayPollingDataFetcher() override {}

bool Start(ConsumerType consumer_type, void* buffer) override {

- EXPECT_TRUE(

- GetPollingMessageLoop()->task_runner()->BelongsToCurrentThread());

+ EXPECT_TRUE(base::MessageLoop::current() == GetPollingMessageLoop());

Init(consumer_type, buffer);

switch (consumer_type) {

@@ -374,8 +369,7 @@

}

bool Stop(ConsumerType consumer_type) override {

- EXPECT_TRUE(

- GetPollingMessageLoop()->task_runner()->BelongsToCurrentThread());

+ EXPECT_TRUE(base::MessageLoop::current() == GetPollingMessageLoop());

switch (consumer_type) {

case CONSUMER_TYPE_MOTION: